Hi @Jason011125
Your commit is good, but we also need to consider the issue of backward compatibility. The existing cluster yaml configuration file writes the hostname field. After upgrading to the curveadm version that includes your pr, an error will be reported when performing related operations. Therefore, we need to ensure the compatibility of the hostname configuration, and it is recommended to use the hostip field in the configuration file of the new version, and discard the hostname field after several versions.

Can you continue to improve this PR?

Hi @Jason011125 Your commit is good, but we also need to consider the issue of backward compatibility. The existing cluster yaml configuration file writes the hostname field. After upgrading to the curveadm version that includes your pr, an error will be reported when performing related operations. Therefore, we need to ensure the compatibility of the hostname configuration, and it is recommended to use the hostip field in the configuration file of the new version, and discard the hostname field after several versions.

Can you continue to improve this PR?

Agree! On the other hand, i think use name to replace host and reserve hostname is a good choise, e.g.

hosts:
  - name: server1
    hostname: 10.0.1.1

OR

hosts:
  - name: server1
    hostname: server1.163.org

Hey guys, can we take another look at the PR as I amend the hostip part to allow upward compatability.